coder / coder/coder-desktop-windows

SVG app icons don't load unless the URL ends in .svg

Open
#91 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
26
Forks
12
Avg merge
6h 50m
Merged PRs (30d)
1

Description

Since there's no `ImageSource` that can load both `.svg` and bitmap images, and instead there's a separate `SvgImageSource` and `BitmapImage`, we currently only attempt to load SVGs when the URL ends in `.svg`. We don't have much control over the actual downloading/caching operations of these sources.

One potential solution is to do a `HEAD` request first to get the `Content-Type` of the image, but it won't be easy to cache that result.

Another would be to download/cache images ourselves.

Relates to #92

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing how URL-based images select between SvgImageSource and BitmapImage, focusing on the current `.svg` suffix check. Review the downloading and caching behavior, then compare the HEAD/Content-Type and application-managed caching options described in the issue. Done means SVG icons load when their URLs do not end in `.svg`, without breaking bitmap image loading.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.