coder / coder/coder-desktop-windows
Use dependency injection in more places
- Lingua principale
- C#
- Stelle
- 26
- Fork
- 12
- Merge medio
- 6h 50m
- PR unite (30g)
- 1
Descrizione
In some places where we need to pass parameters that aren't DI-able, we are using a pattern of DI-ing the fields to the "parent" and then passing them to the new child without using DI.
Ideally we use DI as much as possible and not pass stuff down. We may need to use factories to accomplish this.
E.g.
```cs
class MyClass(ISomethingProvider somethingProvider)
{
public ChildClass CreateChild(string myParam)
{
return new ChildClass(somethingProvider, myParam);
}
}
```
https://github.com/coder/coder-desktop-windows/blob/a58864eb60643309cce9d0aa67681fff551ff1b8/App/Views/FileSyncListWindow.xaml.cs#L19
Also the yet to be merged remote directory picker contains an instance of this too.
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.