coder / coder/code-server

--reconnection-grace-time does not survive closing the browser tab

未关闭
#7,955 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug needs-investigation
主要语言
TypeScript
星标
79.3k
派生
6.8k
平均合并
2 天 6 小时
30 天内合并 PR
41

描述

## Problem

`--reconnection-grace-time` (added in #7678) is documented as *"Override the reconnection grace time in seconds. Clients who disconnect for longer than this duration will need to reload the window."*

In practice the setting cannot deliver that, for two independent reasons.

**1. Closing the tab bypasses the grace time entirely.**

`BrowserLifecycleService` listens on `pagehide`/`beforeunload` and runs the workbench shutdown, which disposes the remote connection *gracefully*. On the server, `ManagementConnection` treats a graceful dispose as a finished client:

```
Event.once(this.protocol.onDidDispose)(() => {
this._log(`The client has disconnected gracefully, so the connection will be disposed.`);
this._cleanResources();
});
```

`_cleanResources()` runs immediately — the grace time is never consulted. So closing the tab kills the session regardless of the configured value.

**2. A second connection cuts the grace time to 5 minutes.**

`RemoteExtensionHostAgentServer` shortens every disconnected connection on each new connection:

```
for (const key in this._managementConnections) {
this._managementConnections[key].shortenReconnectionGraceTimeIfNecessary();
}
```

which schedules `ProtocolConstants.ReconnectionShortGraceTime` (5 min). Opening a second tab is enough to cut a deliberately long grace time back down.

## Impact

The use case the flag exists for — leave a long-running task (a build, a CLI, an agent session) running and come back to it later — does not work. The session is gone as soon as the browser is closed.

## Expected

When an operator raises `--reconnection-grace-time` above the default, a disconnected session should survive for the configured duration, including across a closed browser. Installations that never set the flag should keep Code's stock behaviour.

## Environment

Reproduced on code-server 4.128.0 and confirmed present in `main` (4.133.0 / Code 1.133.0).

贡献指南

打开贡献指南

调研方向

Trace BrowserLifecycleService's pagehide/beforeunload handling and ManagementConnection's graceful-dispose cleanup first. Then inspect RemoteExtensionHostAgentServer's connection-shortening path; done means a configured grace period survives tab closure and a second connection, while installations using the default retain stock behavior.

由索引模型根据 Issue 内容生成。

评估

技术栈
typescript
领域
backend, web-dev
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
55/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。