coder / coder/code-server

localhost openExternal rewrite loses URL /path

Offen
#7,668 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug triage
Vorherrschende Sprache
TypeScript
Sterne
79.3k
Forks
6.8k
Ø Merge
2 T. 6 Std.
Gemergte PRs (30 T.)
41

Beschreibung

### Is there an existing issue for this?

- [x] I have searched the existing issues

### OS/Web Information

- Web Browser: chrome
- Local OS: macOS
- Remote OS: Linux/Ubuntu
- Remote Architecture: amd64
- `code-server --version`: 1.107.0

### Steps to Reproduce

1. `/usr/lib/code-server/lib/vscode/bin/helpers/browser.sh http://127.0.0.1:1234/my/path`
2. Opens URL `https://coder./@//apps/code-server/proxy/1234/`
3. Be saddened by the observation that `/my/path` was dropped during the rewrite.

### Expected

Should have rewritten to URL `https://coder./@//apps/code-server/proxy/1234/my/path` (with trailing `/my/path`). When I update the URL in my browser to do this, this works - so the proxy itself is doing all the right things, it's just the rewrite that is incorrect afaics.

I have not explored with query params or anchors. Given what I see in the code, I suspect these are lost too.

### Actual

Opened URL `https://coder./@//apps/code-server/proxy/1234/`

### Logs

```shell

```

### Screenshot/Video

_No response_

### Does this bug reproduce in native VS Code?

This cannot be tested in native VS Code

### Does this bug reproduce in VS Code web?

I did not test VS Code web

### Does this bug reproduce in GitHub Codespaces?

I did not test GitHub Codespaces

### Are you accessing code-server over a secure context?

- [x] I am using a secure context.

### Notes

I believe the relevant code is part of this code-server patch, and not vscode:
https://github.com/coder/code-server/blob/main/patches/proxy-uri.diff

From a squint at this patch, I think the `new URL(renderedTemplate, window.location.href)` call in `resolveExternalUri` is suspect. I don't see anything here that _would_ copy through anything after the host portion of the URL.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.