coder / coder/code-server

External URLs using wrong URL from cache

未关闭
#6,024 2 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
TypeScript
星标
79.3k
派生
6.8k
平均合并
2 天 6 小时
30 天内合并 PR
41

描述

I found there's a conflict between this feature and url displayed in open external uri dialog.
If you open an external uri for the first time then the domain of it will be resolved to cache in map data structure.
Like https://www.w3schools.com/c/c_structs.php
![image](https://user-images.githubusercontent.com/85340915/218913703-1289dfd8-ba7e-43c4-865c-ce37f0fdc714.png)

For the next time if you open a different uri with the same domain
Like https://github.com/coder/code-server/issues
it will be resolved as the last uri which has been cached.
![image](https://user-images.githubusercontent.com/85340915/218913889-30d0b1a7-486d-4559-933c-23556334a4c9.png)

The uri displayed here is not correct

Before there's no resolvers registered by default so external uri is not resolved but after this feature added, cache will take effect
![image](https://user-images.githubusercontent.com/85340915/218915483-f2bc57a7-0f54-45df-961b-83bd972252df.png)

Hope there's a solutaion for this. Thank you!

_Originally posted by @ericzhucode in https://github.com/coder/code-server/issues/5624#issuecomment-1430673559_

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。