coder / coder/code-server

Store state on remote instead of browser

Aperta
#4,212 39 commenti 15 reazioni 0 assegnatari Vedi su GitHub
enhancement needs-investigation
Lingua principale
TypeScript
Stelle
79.3k
Fork
6.8k
Merge medio
2g 6h
PR unite (30g)
41

Descrizione

**Edit by @code-asher:** Storing the state in the browser has (at least) the two following problems:

1. If you switch to another browser you have to open and configure everything all over again (what this issue was originally about).
2. It is impossible to seed the initial state like you could in native VS Code by writing to the JSON state file.

Original issue content follows.

## OS/Web Information

- Web Browser: Chrome v91
- Local OS: Windows 10
- Remote OS: Ubuntu 20.04
- Remote Architecture: Debian
- `code-server --version`: 3.12.0

## Steps to Reproduce

1. Open a new code server instance in browser and make some changes (eg : hide remote host).
3. Open the same instance in incognito tab.
4. The changed made above will not be reflected, and you have to make those changes again.

## Expected
Till v3.11 the state of code-server was maintained across browsers.

## Actual
The state is saved local storage instead of server and hence the changes does not reflect on browser changes.

## Notes
`scope === StorageScope.GLOBAL ? 'global' : this.payload.id;` it is in workbench.web.api.js.map
Perhaps it's related to where the state is saved?
From discussion : https://github.com/cdr/code-server/discussions/4185

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.