codecov / codecov/codecov-javascript-bundler-plugins

Bundle stats upload fails against AWS S3 storage (chunked Transfer-Encoding → 501 NotImplemented)

Aperta Adatta ai principianti
#351 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
TypeScript
Stelle
9
Fork
10
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Summary

uploadStats sends the stats payload as a streamed request body (ReadableStream + duplex: "half"), which undici serializes with Transfer-Encoding: chunked (no Content-Length). Amazon S3 does not support chunked PUTs and rejects the pre-signed upload with 501 NotImplemented, so bundle analysis is completely non-functional on any self-hosted Codecov instance whose storage backend is real AWS S3.

MinIO (the common self-hosted default) is lenient and accepts chunked, which is likely why this hasn't surfaced widely — but a Codecov Enterprise instance configured with services.minio.host: s3.amazonaws.com hits it every time.

Environment

  • @codecov/vite-plugin 2.0.1 (@codecov/bundler-plugin-core 2.0.1)
  • Node.js v24.14.1
  • Self-hosted Codecov (Enterprise 25.5.1) with storage backend = AWS S3 (services.minio.host: s3.amazonaws.com)

Root cause

In packages/bundler-plugin-core/src/utils/uploadStats.ts the body is a stream:

const stream = new ReadableStream({
  pull(controller) { /* ... enqueue chars ... */ },
}).pipeThrough(new TextEncoderStream());

await fetchWithRetry({
  url: preSignedUrl,
  requestData: {
    method: "PUT",
    headers: { "Content-Type": "application/json" },
    duplex: "half",
    body: stream,   // <-- undici sends Transfer-Encoding: chunked, no Content-Length
  },
});

A streamed body with no known length is sent as Transfer-Encoding: chunked. S3 returns:

<Error>
  <Code>NotImplemented</Code>
  <Message>A header you provided implies functionality that is not implemented</Message>
  <Header>Transfer-Encoding</Header>
</Error>

With a large real payload, S3 responds 501 and closes the socket mid-upload, so undici surfaces it as a low-level TypeError: fetch failed (rethrown from fetchWithRetry) rather than the clean 501 — hence the opaque Failed to upload stats, fetch failed users see. With a tiny payload the full body flushes first and you get the clean 501.

Reproduction

  1. Configure a self-hosted Codecov whose storage is genuine AWS S3.
  2. Run any build with the plugin enabled + CODECOV_TOKEN set, pointing apiUrl at that instance.
  3. Pre-signed URL fetch succeeds; upload-stats fails 3× → Failed to upload stats, fetch failed.

Minimal repro of the underlying HTTP behavior (Node fetch → S3 pre-signed PUT):

// buffered string body -> Content-Length set -> 200 OK
await fetch(preSignedUrl, { method: "PUT", headers: { "Content-Type": "application/json" }, body: statsJson })

// streamed body + duplex:"half" -> Transfer-Encoding: chunked -> 501 NotImplemented
const stream = new ReadableStream({ /* enqueue chars */ }).pipeThrough(new TextEncoderStream())
await fetch(preSignedUrl, { method: "PUT", headers: { "Content-Type": "application/json" }, duplex: "half", body: stream })

Suggested fix

Send the payload as a buffered string/Uint8Array so fetch sets Content-Length, instead of a ReadableStream:

await fetchWithRetry({
  url: preSignedUrl,
  requestData: {
    method: "PUT",
    headers: { "Content-Type": "application/json" },
    body: message,   // string -> Content-Length, S3-compatible
  },
});

The stats JSON is already fully in memory (it's iterated char-by-char to build the stream), so buffering it adds no meaningful memory overhead and makes uploads compatible with S3 as well as MinIO/GCS.

Alternatively, keep streaming but compute and set an explicit Content-Length header, or use S3's aws-chunked content-encoding — but a plain buffered body is by far the simplest and works across all backends.

I've verified the buffered-body change fixes uploads against AWS S3 end-to-end (Successfully uploaded stats). Happy to open a PR if useful.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia in packages/bundler-plugin-core/src/utils/uploadStats.ts e verifica come viene costruito il payload delle statistiche e passato a fetchWithRetry. Verifica che l’upload utilizzi un body di lunghezza nota e testa il plugin con AWS S3 reale; il lavoro è completato quando l’upload delle statistiche del bundle ha esito positivo invece di restituire l’errore 501 di chunked-transfer.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
aws, node.js, typescript
Ambito
cloud
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Tranquilla
Chiarezza
Specificata chiaramente
Idoneità per principianti
82/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.