codeceptjs / codeceptjs/CodeceptJS

`I.waitForFile` (FileSystem helper) fails if directory does not exist (yet)

Abierto
#5,420 1 comentario 0 reacciones 0 asignados Ver en GitHub
stale
Lenguaje dominante
JavaScript
Estrellas
4.2k
Forks
757
Merge medio
2 d 9 h
PR fusionados (30 d)
16

Descripción

`I.waitForFile` sometimes fails and throws weird exceptions if the directory containing the expected file does not exist yet.

Example (all output goes to `${codecept_dir}/output/`):
```js
I.handleDownloads('downloads/example.txt');
I.click('button.download');
I.amInPath('output/downloads');
I.waitForFile('example.txt', 5);
```

If the directory `${codecept_dir}/output/downloads` does not exist yet (it will be created by the browser download at some point in time), the function `I.waitForFile` will throw an exception `ReferenceError: Cannot access 'watcher' before initialization` and the test will fail.

Root cause is in the function [`isFileExists`](https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/FileSystem.js#L202-L227) of the `FileSystem` helper. The line `const watcher = fs.watch(dir, (eventType, filename) => {...` will throw if `dir` does not exist yet. This exception remains unhandled. Later, the timer for the 5sec timeout detection will try to close the uninitialized `watcher`, leading to the `ReferenceError`.

I will try to create a PR.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.