code-saturne / code-saturne/code_saturne

Bug for the initialization of mixture_fraction and mixture_fraction_variance

Open
#81 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
307
Forks
102
PR merge metrics
No merged PRs in 30d

Description

Hi,

There are a bug for the initialization for mixture_fraction and mixture_fraction_variance on the master branch. To solve it, update the zone_id in InitializationView.py:

line 331
zone_id = str(self.zone.getCodeNumber())
exp = self.init.getCombustionFormula(zone_id, self.scalar_combustion)

line 346
zone_id = str(self.zone.getCodeNumber())
exp = self.init.getCombustionFormula(zone_id, self.scalar_combustion)

line 521
zone_id = str(self.zone.getCodeNumber())
exp, req, sym = self.init.getCombustionFormulaComponents(zone_id, self.scalar_combustion)

line 525
dialog = QMegEditorView(parent=self,
function_type="ini",
zone_name=self.zone.getLabel(),
variable_name=name,
expression=exp,
required=req,
symbols=sym,
examples=exa)

and line 535
self.init.setCombustionFormula(zone_id, self.scalar_combustion, str(result))

Cheers

Yohann

Contributor guide

Open the contributing guide

Research direction

Open InitializationView.py and inspect the initialization paths around lines 331, 346, 521, 525, and 535, focusing on how zone_id is obtained and passed to the combustion-formula methods. Reproduce the mixture_fraction and mixture_fraction_variance initialization issue, then verify both variables initialize correctly for the relevant zone.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.