code-corps / code-corps/code-corps-ember

Skip update selection in task assignment if change is processing

未关闭
#1,486 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
120
派生
75
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

Right now, this code below, found in `components/task-assignment`, updates the user selection when it changes.

```didReceiveAttrs() {
let { taskUserId, users } = getProperties(this, 'taskUserId', 'users');
if (users) {
set(this, 'selectedOption', users.findBy('id', taskUserId));
}
},```

However, this updates while the change is still processing, and rolls back if it fails. It'd be preferred if for the update to be skipped if the change is processing. It also fails to roll back when reassignment fails.

## References
#1435

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。