code-corps / code-corps/code-corps-api

Add available GithubAppInstallations to a user

Aperta
#853 3 commenti 0 reazioni 1 assegnatario Rivendicata da @begedin Vedi su GitHub
Difficulty: Medium in progress question Skill: Elixir Skill: Phoenix Time: 4 hours
Lingua principale
Elixir
Stelle
234
Fork
82
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

# Problem

We need to find a way to add available `GithubAppInstallations` for a `User` that the user has access to for the GitHub App.

We'll have to refresh this data by hitting [GitHub's API endpoint](https://developer.github.com/v3/apps/#list-installations-for-user) for listing a user's installations.

We may want an endpoint for this at our own `/user/github-app-installations`. We could also consider having this simply be available to a `User` on the `UserView`, but this may confuse things with an existing `GithubAppInstallations` relationship. We could perhaps rename the key to something like `available-github-app-installations` but keep the type `github-app-installation`.

Alternatively, we could also rename the `user` relationship in `GithubAppInstallation` to `sender`, which is more in-line with GitHub's own API and can reduce some confusion there.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.