code-corps / code-corps/code-corps-api

Move status logic from StripeAccountView into a separate module

未关闭
#599 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Difficulty: Easy
主要语言
Elixir
星标
234
派生
82
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

The `StripeConnectAccountView` logic [here](https://github.com/code-corps/code-corps-api/blob/develop/web/views/stripe_connect_account_view.ex#L78-L165) can be moved into a separate module, with only the basic placeholder fields remaining in the view, to simplify things:

```Elixir

def recipient_status(record, _conn), do: AccountVerificationStatus.recipient(record)
def bank_account_status(record, _conn), do: AccountVerificationStatus.bank_account(record)
def personal_id_number_status(record, _conn), do: AccountVerificationStatus.personal_id_number(record)
def verification_document_status(record, _conn), do: AccountVerificationStatus.verification_document(record)

```
## Subtasks
- [ ] Move logic to separate module
- [ ] Add "delegation" methods to view
- [ ] Add tests for module, simplify tests for view

# Discussion

Where do we put the module? I'm thinking something like `lib/code_corps/presenters/account_verification_status.ex`. Could use your thoughts, @joshsmith.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。