code-corps / code-corps/code-corps-api

UserService might need to become an async task

Aberta
#548 3 comentários 0 reações 0 responsáveis Ver no GitHub
blocked
Linguagem predominante
Elixir
Estrelas
234
Forks
82
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

# Problem

Right now, the user service does the following in a single transaction

- updates the user
- updates the associated platform customer record locally
- updates the associated platform customer record on stripe
- updates the associated connect customer records locally (can be multiple)
- updates the associated connect customer records on stripe (can be multiple)

That's a lot of work for a synchronous process. It would make sense to make it an async task.

However, this process is triggered by the user updating their profile, so we do need to update the user record itself immediately, and reply with the updated record to the client.

This means that, in order to make it an async task, we would have to lose the benefits of it being a transaction.

Taking that into consideration, we need to discuss a potential solution (if we need to change anything at all).

One option would be to add a flag to the user database indicating that the account is out of sync with the associated stripe accounts. We could then periodically retry in a background worker of some sort.

Alternatively, a more encompassing solution would be to store background tasks somewhere and retry the failed ones. Really, I'm not sure what the proper way of dealing with this in Elixir would be, compared to Rails.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.