code-corps / code-corps/code-corps-api

Replace json_payload strategy with DockYard's json_api_assert

未關閉
#490 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug feature
主要語言
Elixir
星號
234
分支
82
PR 合併指標
30 天內沒有已合併 PR

描述

# Problem

Our `json_payload` strategy breaks down when the view is not rendering attributes used during record creation. The reason for that is, the strategy takes a built record, infers the view from the type of record and then uses that view to build a json api payload.

If the view does not render an attribute which is usually used to create that record, then creation fails in various ways, depending on the specific case.

I was hoping `ja_serializer` had a convenient helper which would render a record into a json_payload using ALL attributes, and created an issue about that in the repo

https://github.com/vt-elixir/ja_serializer/issues/196#issuecomment-262529168

While the response was that there is no such helper, I was pointed in the direction of https://github.com/DockYard/json_api_assert, which does seem to have such a serializer.

## Subtasks
- [ ] Try to use DockYard/json_api_assert to improve our json_api_payload strategy
- [ ] If that doesn't work, try the reflection route described in the linked issue

## References
* vt-elixir/ja_serializer#196
* https://github.com/DockYard/json_api_assert

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。