code-corps / code-corps/code-corps-api

Write tests for GitHub.Sync.pull_request_event/1

未關閉
#1,372 3 則留言 0 個 reaction 已指派 1 人 已指派給 @zacck-zz 在 GitHub 檢視
Difficulty: Medium Skill: Elixir Time: 4 hours
主要語言
Elixir
星號
234
分支
82
PR 合併指標
30 天內沒有已合併 PR

描述

# Problem

`GitHub.Sync.pull_request_event/1` is currently completely untested. Since we want to unit test it's individual elements to, it should suffice to test each possible outcome of the transaction performed by the tests, as defined by `GitHub.Sync.pull_request_event_outcome()`

## Subtasks
- [x] write test for `{:ok, map}` outcome
- [x] write test for `{:error, :repo_not_found}` outcome
- [x] write test for `{:error, :fetching_issue, struct}` outcome
- [x] write test for `{:error, :validating_github_pull_request, Changeset.t()}` outcome
- [ ] write test for `{:error, :validating_github_issue, Changeset.t()}` outcome
- [ ] write test for `{:error, :validating_user, Changeset.t()}` outcome
- [ ] write test for `{:error, :multiple_issue_users_match}` outcome
- [x] write test for `{:error, :validating_task, Changeset.t()}` outcome
- [ ] write test for `{:error, :unexpected_transaction_outcome, any}` outcome

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。