code-corps / code-corps/code-corps-api

RFC: Is organization/project approval still relevant?

未关闭
#1,231 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
needs clarification question RFC
主要语言
Elixir
星标
234
派生
82
PR 合并指标
30 天内没有已合并 PR

描述

We added an `approved` column to projects and organizations almost a year ago. I'm not sure if we had the organization invite system in mind when adding it.

The way I see it, the columns could still be relevant.

# Keep the columns

- once a user creates an organization and a project, the ember app tells them the two "still need to be approved by an administrator"
- the ember app indicates/shows reduced UI for unapproved projects/organizations

There is then the question of how to most effectively filter out unapproved records

## Option A

- the index actions for organizations and projects should only list approved items, if no filters are applied
- the show action and the index actions when filtered to specific ids, should still list all records
- that means unapproved records are unlisted, but can still be reached by direct url, where they are shown in a reduced state

## Option B

- index and show should be scoped to current user
- owner can see all approved and their own unapproved records
- regular user can only see approved records
- this means unapproved records are not reachable by regular users

# Drop the columns

- Organizations can only be created by admins or via invites - no changes other than normal milestone changes.
- Project creation creates a problem of organization owner being able to create multiple projects once they create the organization. We could fix by
- adding a project limit of 1 to each organization
- we can always manually increase the limit for select organizations, if we want to

A potential problem with dropping the approved columns will be that the user could always do something bad, even a user we trust enough to send an invite to.

Once (hopefully) CodeCorps gets big enough, we will probably have direct org/project creation, not via invites. We'll need an approval system at that point anyway.

# We could also do both

We could keep the columns in, but auto-approve an organization created via invite and also maybe auto-approve the first project created by such organization.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。