code-corps / code-corps/code-corps-api

Handle missing issuer claim for GitHub JWT

Abierto
#1,129 1 comentario 0 reacciones 0 asignados Ver en GitHub
Priority: Low
Lenguaje dominante
Elixir
Estrellas
234
Forks
82
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

# Problem

If we're lacking the proper ENV variables for getting an integrations token, we'll get the following for code that tries to exchange our application credentials for a token:

```
(MatchError) no match of right hand side value: {:error, %CodeCorps.GitHub.APIError{documentation_url: "https://developer.github.com/v3", errors: nil, message: "Missing 'issuer' claim ('iss') in assertion", status_code: 401}}
```

We should handle this error more directly by explaining what's happening here (i.e. you're missing some configuration that makes JWT work).

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.