code-corps / code-corps/code-corps-api

Reorganize GitHub modules

Abierto
#1,092 4 comentarios 0 reacciones 1 asignado Reclamado por @begedin Ver en GitHub
in progress needs estimate
Lenguaje dominante
Elixir
Estrellas
234
Forks
82
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

# Problem

Much of the GitHub syncing can be reorganized as follows:

- [x] `CommentSyncer` and `TaskSyncer` need to move out of `Event`; structure could be like:
- `sync/issue/issue.ex` `Sync.Issue` (main entry point for handling the syncing of an issue)
- `sync/issue/body_parser.ex` `Sync.Issue.BodyParser` (parses issue body)
- `sync/issue/task/task.ex` `Sync.Issue.Task` (syncs the issue to a `Task`)
- `sync/issue/task/changeset.ex` `Sync.Issue.Task.Changeset` (deals with changesets)
- `sync/issue/github_issue/github_issue.ex` `Sync.Issue.GithubIssue` (syncs the issue to a `GithubIssue`)
- etc.
- [x] `ChangesetBuilder`s
- [x] need to move out event to wherever syncing goes
- [x] `map` can be removed
- [x] naming needs to be rethought to reflect that these are changesets for Code Corps models (`Task`, `Comment`, etc)
- [ ] `GithubRepo` installation events need to have `common/repo_finder` (renamed to `repo_linker`)
- [x] `CommentDeleter` needs to move out of `Event`
- [x] `CommentDeleter` needs to delete `GithubComment`
- [x] `ChangesetBuilder`s need `create_` and `update_` functions made public, `build_` fns removed, unit tests added
- [ ] Replace instances of `find_or_init` and `commit` with insert_or_update and find


Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.