code-corps / code-corps/code-corps-api

Add fallback for GitHub avatars when async processing

未关闭
#1,017 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
needs estimate
主要语言
Elixir
星标
234
派生
82
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

For the fallback:

- Rewrites the `cloudinary_image/5` fn signature to accept the `User`'s `github_avatar_url` in addition to the `cloudinary_public_id`
- In `CloudinaryUrl.for/5`, pattern match on the presence of a `github_avatar_url` in order to instead use the GitHub avatar URL as a fallback (with the right sizing options)
- Test the `ImagePresenter` and `CloudinaryUrl` modules accordingly

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。