code-corps / code-corps/code-corps-api

Add fallback for GitHub avatars when async processing

Open
#1,017 0 comments 0 reactions 0 assignees View on GitHub
needs estimate
Dominant language
Elixir
Stars
234
Forks
82
PR merge metrics
No merged PRs in 30d

Description

# Problem

For the fallback:

- Rewrites the `cloudinary_image/5` fn signature to accept the `User`'s `github_avatar_url` in addition to the `cloudinary_public_id`
- In `CloudinaryUrl.for/5`, pattern match on the presence of a `github_avatar_url` in order to instead use the GitHub avatar URL as a fallback (with the right sizing options)
- Test the `ImagePresenter` and `CloudinaryUrl` modules accordingly

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.