cockroachdb / cockroachdb/sequelize-cockroachdb

Error message when closing a connection too soon

Abierto
#149 0 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
55
Forks
18
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

This example code outputs an error:

```
const { Sequelize } = require("sequelize-cockroachdb");

const sequelize = new Sequelize(process.env.DATABASE_URL);

(async () => {
try {
const [results, metadata] = await sequelize.query("SELECT NOW()");
console.log(results);
} catch (err) {
console.error("error executing query:", err);
} finally {
await sequelize.close();
}
})();
```

The error is as follows:

```
Executing (default): SELECT version() AS version
Executing (default): SELECT NOW()
Executing (default): SELECT crdb_internal.increment_feature_counter(concat('Sequelize ', '6.19'))
[ { now: 2022-05-23T20:29:50.787Z } ]
Could not record telemetry.
Error: ConnectionManager.getConnection was called after the connection manager was closed!
```

We suspect that this problem was because the connection was closed quickly. However, the user didn't really do anything wrong in this case, nor do they likely care whether the telemetry was recorded successfully. Suggested solution: don't output a user-facing error when we fail to record telemetry.

CC @rafiss @RichardJCai

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.