cockroachdb / cockroachdb/errors

Stop relying on `pkg/errors` to handle stack traces

Abierto
#70 7 comentarios 7 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Go
Estrellas
2.5k
Forks
74
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Today the stack trace formatting code delegates to `pkg/errors/stack.go`.

However, that code uses `runtime.FuncForPC` and emits file paths in the stack trace derived from the raw file name of the source file.

This method is outdated, as the on-disk file name of a given package's source may be different from the package path (due to go mod versioning, reproducible build sandboxes, etc).

The "modern" equivalent is `runtime.CallersFrame`, which populates `runtime.Frame` structs with package path-qualified function names.

We want to use that instead.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.