cockroachdb / cockroachdb/cockroachdb-parser

[sql/sem/tree]: Pretty-printed tuples are always formatted with comma

Open
#10 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
43
Forks
12
PR merge metrics
No merged PRs in 30d

Description

We're using the `tree` package to format auto-generated SQL for tests. It's very useful for this, thanks for the work that has gone into this package.

One thing that we came across is that tuples are formatted with a trailing comma when there's a single item in it:

https://github.com/cockroachdb/cockroachdb-parser/blob/302c9ad52e1a81d9cf51398875c45333a1c6d635/pkg/sql/sem/tree/pretty.go#L1124-L1126

While this is equivalent, the output is a bit unexpected

Input

```sql
SELECT * FROM some_table WHERE (some_column IN ('abc'))
```

Output

```sql
SELECT * FROM some_table WHERE some_column IN ('abc',);
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.