cockroachdb / cockroachdb/cockroach-operator

Build Clean Up and Developer Effeciency

Offen
#437 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @alinadonisa Auf GitHub ansehen
Vorherrschende Sprache
Go
Sterne
318
Forks
104
Ø Merge
1 T. 6 Std.
Gemergte PRs (30 T.)
1

Beschreibung

We have default values set in multiple places. Primarily the Makefile and https://github.com/cockroachdb/cockroach-operator/blob/master/hack/build/version.sh, which is when we run bazel with `--stamp.`

Here are the main efforts with this issue:

1. Move as much as possible into bazel - release, development, scripts, etc. We need to run bazel commands to do everything, including releases.
2. Put error handling in `version.sh`
2. Move as much as possible out of the Makefile
2. Use a .bazelrc file https://docs.bazel.build/versions/master/guide.html#bazelrc-the-bazel-configuration-file to drive the effort
3. Document it
4. Test it

Have variables, such as version numbers, docker registry locations, in a `.bazelrc` file, which is not changed except with releases. We can use `--config` as well and might be able to have a single bazel config file, or we can have a developer example `.bazelrc` file and then a release `.bazelrc` file.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.