cockroachdb / cockroachdb/cockroach-operator

Openshift related image generation should completely overwrite the manifest values

未关闭
#406 3 条评论 0 个 reaction 已指派 1 人 已被 @alinadonisa 认领 在 GitHub 查看
bug
主要语言
Go
星标
318
派生
104
平均合并
1 天 6 小时
30 天内合并 PR
1

描述

In the OpenShift release to support more versions for the cockroach db, currently we need to add the supported versions in the patch file https://github.com/cockroachdb/cockroach-operator/blob/master/manifests/patches/deployment_patch.yaml and also in the file https://github.com/cockroachdb/cockroach-operator/blob/master/hack/update-pkg-manifest.sh#L60.

We are using Kustomize that it is applied on the file https://github.com/cockroachdb/cockroach-operator/blob/master/manifests/operator.yaml. This causes multiple issues:

- multiple places where the versions are added;
- we are using the merge patch strategy for Kustomize and if there are **related_images env vars** or **other env vars** that are not added to Red Hat installation (not added [here](https://github.com/cockroachdb/cockroach-operator/blob/master/manifests/patches/deployment_patch.yaml)) the values from the operator.yaml are kept the way they are defined, with docker registry.

If the release with the images is specific to Openshift only, please do not add more related_images env var to the operator.yaml, add them only on the patch file.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。