cockroachdb / cockroachdb/cockroach-operator

Further work on CockroachDB Version Validator

Open
#327 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
318
Forks
104
Avg merge
1d 6h
Merged PRs (30d)
1

Description

To DO for PR https://github.com/cockroachdb/cockroach-operator/pull/320 :

1. See @chrisseto and @chrislovecnm suggestions on version checker:
- These errors could be avoided by instead checking the pod's readiness or using the log method described above. Detecting errors based on strings is pretty flakey.
- If we're execing into the job pod, what is the job pod doing? Would it make more sense for the job to run the above command and then have this code parse the output via the logs API?
- IsJobPodRunning function is misleading, it doesn't actually wait for the pod to report itself as ready. There's a helper in the k8s SDK to check the readiness of a pod. You could also use a field selector.
- I find it helpful to make Unknown the zero value for these types of enums. As is, it wouldn't be possible to tell the difference between an uninitialized value and Failed which might result in some strange bugs.
2. Add refactory for Actor method Handles
3. Add SupportedCrdbImages tests

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.