cockroachdb / cockroachdb/activerecord-cockroachdb-adapter

[Tracking] Outstanding ActiveRecord 5.2 tests

Aperta
#48 6 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
Ruby
Stelle
105
Fork
56
Merge medio
9h 5m
PR unite (30g)
3

Descrizione

Below is a list of all the ActiveRecord tests that get run against PostgreSQL on Rails 5.2. Check off tests once they're passing against master.

There will be tests that don't work against CockroachDB. To skip these tests

1. Add a ruby file to `test/excludes` that matches the name of the test class if one doesn't already exist. For example to exclude a test from `ActiveRecord::AdapterTest`, create `test/excludes/ActiveRecord/AdapterTest.rb`.
1. Add an exclude statement to the file with the name of the test to exclude and a description. For example to exclude `test_indexes` from `ActiveRecord::AdapterTest`:
https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/c3cb637bd855b36bbf9e76b7947162054b95022e/test/excludes/ActiveRecord/AdapterTest.rb#L1
1. Finally, if the test can run against CockroachDB with a few changes, add it to `test/cases`. Everything from the ActiveRecord test suite will be available, so a lot of the excluded test can be copied over. Namespace the test under the `CockroachDB` module to avoid name collisions. See [`test/cases/adapter_test.rb`](https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/c3cb637bd855b36bbf9e76b7947162054b95022e/test/cases/adapter_test.rb) for an example.

For information on running tests, see the [Contributing guide](https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/master/CONTRIBUTING.md#setup-and-running-tests).

## ActiveRecord tests
- [x] test/cases/adapter_test.rb
- [x] test/cases/adapters/postgresql/active_schema_test.rb
- [ ] test/cases/adapters/postgresql/array_test.rb
- [ ] test/cases/adapters/postgresql/bit_string_test.rb
- [ ] test/cases/adapters/postgresql/bytea_test.rb
- [ ] test/cases/adapters/postgresql/case_insensitive_test.rb
- [x] test/cases/adapters/postgresql/change_schema_test.rb
- [x] test/cases/adapters/postgresql/cidr_test.rb
- [ ] test/cases/adapters/postgresql/citext_test.rb
- [ ] test/cases/adapters/postgresql/collation_test.rb
- [x] test/cases/adapters/postgresql/composite_test.rb
- [ ] test/cases/adapters/postgresql/connection_test.rb
- [ ] test/cases/adapters/postgresql/datatype_test.rb
- [x] test/cases/adapters/postgresql/date_test.rb
- [ ] test/cases/adapters/postgresql/domain_test.rb
- [x] test/cases/adapters/postgresql/enum_test.rb
- [ ] test/cases/adapters/postgresql/explain_test.rb
- [ ] test/cases/adapters/postgresql/extension_migration_test.rb
- [ ] test/cases/adapters/postgresql/foreign_table_test.rb
- [ ] test/cases/adapters/postgresql/full_text_test.rb
- [x] test/cases/adapters/postgresql/geometric_test.rb
- [ ] test/cases/adapters/postgresql/hstore_test.rb
- [ ] test/cases/adapters/postgresql/infinity_test.rb
- [x] test/cases/adapters/postgresql/integer_test.rb
- [x] test/cases/adapters/postgresql/json_test.rb
- [x] test/cases/adapters/postgresql/ltree_test.rb
- [x] test/cases/adapters/postgresql/money_test.rb
- [ ] test/cases/adapters/postgresql/network_test.rb
- [ ] test/cases/adapters/postgresql/numbers_test.rb
- [x] test/cases/adapters/postgresql/partitions_test.rb
- [ ] test/cases/adapters/postgresql/postgresql_adapter_test.rb
- [x] test/cases/adapters/postgresql/prepared_statements_disabled_test.rb
- [x] test/cases/adapters/postgresql/quoting_test.rb
- [x] test/cases/adapters/postgresql/range_test.rb
- [ ] test/cases/adapters/postgresql/referential_integrity_test.rb
- [ ] test/cases/adapters/postgresql/rename_table_test.rb
- [x] test/cases/adapters/postgresql/schema_authorization_test.rb
- [x] test/cases/adapters/postgresql/schema_test.rb
- [x] test/cases/adapters/postgresql/serial_test.rb
- [x] test/cases/adapters/postgresql/statement_pool_test.rb
- [ ] test/cases/adapters/postgresql/timestamp_test.rb
- [ ] test/cases/adapters/postgresql/transaction_test.rb
- [ ] test/cases/adapters/postgresql/type_lookup_test.rb
- [x] test/cases/adapters/postgresql/utils_test.rb
- [ ] test/cases/adapters/postgresql/uuid_test.rb
- [x] test/cases/adapters/postgresql/xml_test.rb
- [x] test/cases/aggregations_test.rb
- [x] test/cases/ar_schema_test.rb
- [x] test/cases/associations/cascaded_eager_loading_test.rb
- [x] test/cases/associations/belongs_to_associations_test.rb
- [x] test/cases/associations/bidirectional_destroy_dependencies_test.rb
- [x] test/cases/associations/callbacks_test.rb
- [x] test/cases/associations/eager_load_includes_ful l_sti_class_test.rb
- [x] test/cases/associations/eager_load_nested_include_test.rb
- [x] test/cases/associations/eager_singularization_test.rb
- [x] test/cases/associations/eager_test.rb
- [x] test/cases/associations/extension_test.rb
- [x] test/cases/associations/has_and_belongs_to_many_associations_test.rb
- [x] test/cases/associations/has_many_associations_test.rb
- [x] test/cases/associations/has_many_through_associations_test.rb
- [x] test/cases/associations/has_one_associations_test.rb
- [x] test/cases/associations/has_one_through_associations_test.rb
- [x] test/cases/associations/inner_join_association_test.rb
- [x] test/cases/associations/inverse_associations_test.rb
- [x] test/cases/associations/join_model_test.rb
- [x] test/cases/associations/left_outer_join_association_test.rb
- [x] test/cases/associations/nested_through_associations_test.rb
- [x] test/cases/associations/required_test.rb
- [x] test/cases/associations_test.rb
- [x] test/cases/attribute_decorators_test.rb
- [x] test/cases/attribute_methods/read_test.rb
- [x] test/cases/attribute_methods_test.rb
- [x] test/cases/attributes_test.rb
- [x] test/cases/autosave_association_test.rb
- [x] test/cases/base_test.rb (There might be problems running this test on macOS. https://github.com/cockroachdb/activerecord-cockroachdb-adapter/pull/62)
- [x] test/cases/batches_test.rb
- [x] test/cases/binary_test.rb
- [x] test/cases/bind_parameter_test.rb
- [x] test/cases/boolean_test.rb
- [x] test/cases/cache_key_ test.rb
- [x] test/cases/calculations_test.rb
- [x] test/cases/callbacks_test.rb
- [x] test/cases/clone_test.rb
- [x] test/cases/coders/json_test.rb
- [x] test/cases/coders/yaml_column_test.rb
- [x] test/cases/collection_cache_key_test.rb
- [x] test/cases/column_alias_test.rb
- [x] test/cases/column_definition_test.rb
- [x] test/cases/comment_test.rb
- [x] test/cases/connecti on_adapters/schema_cache_test.rb
- [x] test/cases/connection_adapters/adapter_leasing_test.rb
- [x] test/cases/connection_adapters/connection_handler_test.rb
- [x] test/cases/connection_adapters/connection_specification_test.rb
- [x] test/cases/connection_adapters/merge_and_resolve_default_url_config_test.rb
- [x] test/cases/connection_adapters/mysql_type_lookup_test.rb
- [x] test/cases/connection_adapters/type_lookup_test.rb
- [x] test/cases/connection_management_test.rb
- [x] test/cases/connection_pool_test.rb
- [x] test/cases/connection_specification/resolver_test.rb
- [x] test/cases/core_test.rb
- [x] test/cases/counter_cache_test.rb
- [x] test/cases/custom_locking_test.rb
- [x] test/cases/database_statements_test.rb
- [x] test/cases/date_test.rb
- [x] test/cases/date_time_precision_test.rb
- [x] test/cases/date_time_test.rb
- [x] test/cases/defaults_test.rb
- [x] test/cases/dirty_test.rb
- [x] test/cases/disconnected_test.rb
- [x] test/cases/dup_test.rb
- [x] test/cases/enum_test.rb
- [x] test/cases/errors_test.rb
- [x] test/cases/explain_subscriber_test.rb
- [x] test/cases/explain_test.rb
- [x] test/cases/finder_respond_to_test.rb
- [x] test/cases/finder_test.rb
- [x] test/cases/fixture_set/file_test.rb
- [x] test/cases/fixtures_test.rb (Ocassionaly fails locally. Curious to see how it does against CI.)
- [x] test/cases/forbidden_attributes_protection_test.rb
- [x] test/cases/habtm_destroy_order_test.rb
- [x] test/cases/hot_compatibility_test.rb
- [x] test/cases/i18n_test.rb
- [x] test/cases/inheritance_test.rb
- [x] test/cases/instrumentation_test.rb
- [x] test/cases/integration_test.rb
- [x] test/cases/invalid_connection_test.rb
- [x] test/cases/invertible_migration_test.rb
- [x] test/cases/json_attribute_test.rb
- [x] test/cases/json_serialization_test.rb
- [x] test/cases/locking_test.rb
- [x] test/cases/log_subscriber_test.rb
- [ ] test/cases/migration/change_schema_test.rb
- [x] test/cases/migration/change_table_test.rb
- [x] test/cases/migration/column_attributes_test.rb
- [x] test/cases/migration/column_positioning_test.rb
- [ ] test/cases/migration/columns_test.rb
- [x] test/cases/migration/command_recorder_test.rb
- [ ] test/cases/migration/compatibility_test.rb
- [ ] test/cases/migration/create_join_table_test.rb
- [ ] test/cases/migration/foreign_key_test.rb
- [ ] test/cases/migration/index_test.rb
- [x] test/cases/migration/logger_test.rb
- [x] test/cases/migration/pending_migrations_test.rb
- [ ] test/cases/migration/references_foreign_key _test.rb
- [ ] test/cases/migration/references_index_test.rb
- [ ] test/cases/migration/references_statements_test.rb
- [x] test/cases/migration/rename_tabl e_test.rb
- [ ] test/cases/migration_test.rb
- [x] test/cases/migrator_test.rb
- [x] test/cases/mixin_test.rb
- [x] test/cases/modules_test.rb
- [x] test/cases/multiparameter_attributes_test.rb
- [x] test/cases/multiple_db_test.rb
- [x] test/cases/nested_attributes_test.rb
- [x] test/cases/nested_attributes_with_callbacks_test .rb
- [x] test/cases/null_relation_test.rb
- [x] test/cases/numeric_data_test.rb
- [ ] test/cases/persistence_test.rb
- [x] test/cases/pooled_connections_test.rb
- [x] test/cases/primary_keys_test.rb
- [x] test/cases/query_cache_test.rb
- [x] test/cases/quoting_test.rb
- [x] test/cases/readonly_test.rb
- [x] test/cases/reaper_test.rb
- [x] test/cases/reflection_test.rb
- [x] test/cases/relation/delegation_test.rb
- [x] test/cases/relation/merging_test.rb
- [x] test/cases/relation/mutation_test.rb
- [ ] test/cases/relation/or_test.rb
- [x] test/cases/relation/predicate_builder_test.rb
- [x] test/cases/relation/record_fetch_warning_test.rb
- [x] test/cases/relation/where_chain_test.rb
- [x] test/cases/relation/where_clause_test.rb
- [x] test/cases/relation/where_test.rb
- [x] test/cases/relation_test.rb
- [x] test/cases/relations_test.rb
- [ ] test/cases/reload_models_test.rb
- [x] test/cases/reserved_word_test.r b
- [x] test/cases/result_test.rb
- [x] test/cases/sanitize_test.rb
- [ ] test/cases/schema_dumper_test.rb
- [x] test/cases/schema_loading_test.rb
- [ ] test/cases/scoping/default_scoping_test.rb
- [x] test/cases/scoping/named_scoping_test.rb
- [x] test/cases/scoping/relation_scoping_test.rb
- [x] test/cases/secure_token_test.rb
- [x] test/cases/serialization_test.rb
- [x] test/cases/serialized_attribute_test.rb
- [x] test/cases/statement_cache_test.rb
- [x] test/cases/store_test.rb
- [x] test/cases/suppressor_test.rb
- [x] test/cases/tasks/database_tasks_test.rb
- [x] test/cases/tasks/mysql_rake_test.rb
- [x] test/cases/tasks/postgresql_rake_test.rb
- [x] test/cases/tasks/sqlite_rake_test.rb
- [x] test/cases/test_fixtures_test.rb
- [x] test/cases/time_precision_test.rb
- [x] test/cases/timestamp_test.rb
- [x] test/cases/touch_later_test.rb
- [x] test/cases/transaction_callbacks_test.rb
- [x] test/cases/transaction_isolation_test.rb
- [x] test/cases/transactions_test.rb
- [x] test/cases/type/adapter_specific_registry_test.rb
- [x] test/cases/type/date_time_test.rb
- [x] test/cases/type/integer_test.rb
- [x] test/cases/type/string_test.rb
- [x] test/cases/type/type_map_test.rb
- [x] test/cases/type/unsigned_integer_test.rb
- [x] test/cases/type_test.rb
- [x] test/cases/types_test.rb
- [x] test/cases/unconnected_test.rb
- [x] test/cases/unsafe_raw_sql_test.rb
- [x] test/cases/validations/absence_validation_test.rb
- [x] test/cases/validations/association_validation_test.rb
- [x] test/cases/validations/i18n_generate_message_validation_test.rb
- [x] test/cases/validations/i18n_validation_test.rb
- [x] test/cases/validations/length_validation_test.rb
- [x] test/cases/validations/presence_validation_test.rb
- [x] test/cases/validations/uniqueness_validation_test.rb
- [x] test/cases/validations_test.rb
- [x] test/cases/view_test.rb
- [x] test/cases/yaml_serialization_test.rb

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.