cockroachdb / cockroachdb/activerecord-cockroachdb-adapter

Verify overloads of `==`, `hash` and `*_coder` methods

Aperta
#390 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Ruby
Stelle
105
Fork
56
Merge medio
9h 5m
PR unite (30g)
3

Descrizione

Going to rails 8.1, I saw that we were missing some overrides, which made some tests flaky due to rails' deduplicable logic. But mostly, which was wrong!

Since we want to publish 8.1 quickly, and the bug is already here anyway. I'll mark the code with some `TODO` referencing this issue. We'll need to both address theses TODOs and check if there are other places where deduplication is failing.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.