cloudfour / cloudfour/cloudfour.com-patterns

Consider matching DOM order for Sky Nav elements when JS is disabled for better accessibility

Offen
#1,994 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
⁉️ question 🎨 design 🦮 a11y
Vorherrschende Sprache
SCSS
Sterne
26
Forks
3
Ø Merge
19 Std. 32 Min.
Gemergte PRs (30 T.)
81

Beschreibung

When JS is disabled:
- the "Menu" button is hidden
- the Sky Nav is open

## Current implementation

The DOM order of the nav does not match the visual order in the current solution:
Current tab order count | Current tab order in action
--- | ---
Screen Shot 2022-08-02 at 9 39 01 AM | ![source-order-current](https://user-images.githubusercontent.com/459757/182430440-70c954b7-2f48-44eb-ba57-ec6de151e657.gif)

## Proposed solution

We should consider allowing the visual order to match the DOM order when JS is disabled. We might even consider centering the Cloud Four logo since the button is not shown:
Proposes tab order count | Proposed tab order in action
--- | ---
Screen Shot 2022-08-02 at 9 46 09 AM | ![source-order-proposal](https://user-images.githubusercontent.com/459757/182430606-c5ad6067-3ca0-4dbb-9830-c53b0ec94eb5.gif)

## Other considerations

- The gradient no longer matches the original design in the proposed solution

## Related

- https://web.dev/visual-order-follows-dom/

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.