cloudfour / cloudfour/cloudfour.com-patterns

Add an Error pattern to help with required component props

Ouverte
#1,690 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
:construction_worker: dev
Langage dominant
SCSS
Étoiles
26
Forks
3
Merge moyen
19 h 32 min
PR mergées (30 j)
81

Description

This is [an idea](https://github.com/cloudfour/cloudfour.com-patterns/pull/1689#issuecomment-1080986815) @calebeby came up with as a way to help make sure required component props are not accidentally missed when using a given component.

> Maybe you could do something with [defined](https://twig.symfony.com/doc/3.x/tests/defined.html)? Maybe render a message instead of the component if a given prop is not defined? 🤔

> Oh yeah that might be helpful. IDK if it's worth it, but we could probably make a error pattern that is very visible/flashy and then go through all our patterns and make them render the error pattern if any of their required props are missing

It may not be a higher priority, but would be helpful throughout the implementation of the components.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.