cloudfour / cloudfour/SimpleSlideView

Determine default changeView behavior based on source order

Abierto
#10 4 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
HTML
Estrellas
257
Forks
31
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Currently, the `changeView` method _requires_ a value for the `action` argument of either `"push"` or `"pop"`.

It would be nice if the source order of the views could determine the action to take in cases where that value is not provided. This could be accomplished by comparing the value of `@$views.index(@$activeView)` with the value of `@$views.index($targetView)`.

This could also allow us to add a new data-attribute, `data-changeview`, which could do _either_ a push or pop depending on the source order.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.