cloudfour / cloudfour/SimpleSlideView
Determine default changeView behavior based on source order
Open
enhancement
- Dominant language
- HTML
- Stars
- 257
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
Currently, the `changeView` method _requires_ a value for the `action` argument of either `"push"` or `"pop"`.
It would be nice if the source order of the views could determine the action to take in cases where that value is not provided. This could be accomplished by comparing the value of `@$views.index(@$activeView)` with the value of `@$views.index($targetView)`.
This could also allow us to add a new data-attribute, `data-changeview`, which could do _either_ a push or pop depending on the source order.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.