cloudflare / cloudflare/stream-react

Multiple rerenders before changing the videoId causes unknown error occured message

Open
#76 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
198
Forks
30
PR merge metrics
No merged PRs in 30d

Description

We found that on a large application, if react rerenders 3-7 times just after page load and the videoId changes inbetween, the player shows an unknown error message and continues to do so every time you change the videoId after that
this means that there's no way to recover from an error like this without unmounting the component and remounting it which isn't really a good solution

I created a reproducable repo here https://github.com/Floffah/cloudflare-stream-error and deployed it so you can test
Make sure to set your network tab to a slightly slower network throttling setting (e.g. Fast 3G)

Contributor guide

Open the contributing guide

Research direction

Start with the linked reproducible repository and run the application while throttling the network to Fast 3G, then reproduce several React rerenders with videoId changes. Trace how the player enters and remains in the unknown-error state; done means changing videoId recovers without unmounting and remounting the component.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.