cloudflare / cloudflare/cloudflare-python

KV Value Update handles Data wrongly

未关闭
#2,519 4 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
506
派生
148
平均合并
3 小时 15 分钟
30 天内合并 PR
1

描述

### Confirm this is a Python library issue and not an underlying Cloudflare API issue.

- [x] This is an issue with the Python library

### Describe the bug

When trying to set a value in the KV Store `metadata` needs to be provided, but gets merged into the `value` and no meta data gets set.

```
In [29]: response = client.kv.namespaces.values.update(key_name="test", value="MY VALUE", metadata="{}", **kv.params)

In [30]: print(client.kv.namespaces.values.get(key_name="test", **kv.params).text())
{"metadata":"{}","value":"MY VALUE"}

In [31]: print(client.kv.namespaces.metadata.get(key_name="test", **kv.params) is None)
True
```
The problem seems to be caused from the whole body of the request being used as the actual value. The behaviour seems to be correct when manually specifying the request's content tye as `multipart/form-data`:

```
In [38]: response = client.kv.namespaces.values.update(key_name="test", value="MY VALUE", metadata="{}", **kv.params, extra_headers={"Content-Type": "multipart/form-data"})

In [39]: print(client.kv.namespaces.values.get(key_name="test", **kv.params).text())
MY VALUE

In [40]: print(client.kv.namespaces.metadata.get(key_name="test", **kv.params))
{}
```
This should probably be the default behaviour as it shouldn't be necessary to explicitly override the content type. On the other hand `metadata` should not be required in which case the whole body could be set as `value`

### To Reproduce

1. Call `values.update()` with a `value` and `metadata`. Both are set as the actual value.
2. `metadata.get()` doesn't return any metadata.
3. Metadata is returned with the value upon calling `values.get()`.

### Code snippets

```Python

```

### OS

Every OS

### Python version

3.12

### Library version

v4.0.0

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。