cloudflare / cloudflare/binary-install
Add Download Progress Bar
- Lingua principale
- JavaScript
- Stelle
- 48
- Fork
- 23
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Hi, I would like to add a download progress bar while installation.
It's because current version will display `Your package has been installed!` even if the package is still downloading.
It will look like the installation is success but the `npm install` not finished.
For example:
```sh
blueworrybear@LAPTOP-0K8IJ0NA:~/projects/covergates-node$ npm install .
> covergates@0.1.6 postinstall /home/blueworrybear/projects/covergates-node
> node ./install.js
Downloading release https://github.com/covergates/covergates/releases/download/v0.1.6/covergates-v0.1.6-linux-amd64.tar.gz
covergates has been installed!
^C
blueworrybear@LAPTOP-0K8IJ0NA:~/projects/covergates-node$
```
I have make a code change, which could be referred here: [add download progress bar](https://github.com/blueworrybear/binary-install/commit/63a0bc8a2467fd581edf9b34690a5d2d9db235f8)
With the update, the stdout will look like:
```sh
blueworrybear@LAPTOP-0K8IJ0NA:~/projects/covergates-node$ npm install .
> covergates@0.1.6 postinstall /home/blueworrybear/projects/covergates-node
> node ./install.js
Downloading release from https://github.com/covergates/covergates/releases/download/v0.1.6/covergates-v0.1.6-linux-amd64.tar.gz
covergates in now installing
downloading [====================] 723152/bps 100% 0.0s
covergates has been installed!
npm WARN eslint-plugin-prettier@3.1.4 requires a peer of prettier@>=1.13.0 but none is installed. You must install peer dependencies yourself.
audited 138 packages in 45.738s
10 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
```
---
I love this project, it's very useful! So please consider this idea. I will make a PR if you agree.
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inizia leggendo install.js e rivedendo il commit referenziato di download-progress. Riproduci l’output di npm install mostrato nella issue, quindi verifica che l’avanzamento del download venga visualizzato mentre viene recuperata la release e che il messaggio di installazione appaia solo al termine del download.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- javascript
- Ambito
- cli
- Tipo di issue
- Funzionalità
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100