cloud-custodian / cloud-custodian/cel-python

Are celpy Environments thread safe?

未关闭
#38 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
documentation help wanted question
主要语言
Python
星标
174
派生
40
PR 合并指标
30 天内没有已合并 PR

描述

Hello!

I was wondering if a celpy Environment instance could be shared amongst threads, or if we should create a new instance when we want to create a runner for a new expression.

I tried to look through the docs and source code but didn't find any reference to this.

One thing I've noticed though is that, when we call the program method, the code is doing an intermediate assignment to an instance variable of the environment, before returning, which I believe can be problematic in terms of thread preemption.
```
self.runnable = runner_class(self, expr, functions)
return self.runnable
```

Nonetheless I might have missed something and would like to get your feedback on this use case.

Thank you very much!

贡献指南

这个仓库没有索引到贡献指南

调研方向

Issue 提到了 Environment.program 和 self.runnable 的赋值,但没有指定文件或测试。首先跟踪该实现,并在文档和源代码中搜索现有的线程安全保证;如果没有覆盖率,则测试共享使用和按线程使用 Environment 的情况。完成的标准是给出关于支持哪种用法的明确答复,并通过文档或回归测试体现出来。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
documentation
Issue 类型
文档
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。