chipsalliance / chipsalliance/rocket-chip

Issue in VTestDriver__Trace__2__Slow.cpp

Open
#3,672 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
3.9k
Forks
1.3k
Avg merge
5d 13m
Merged PRs (30d)
1

Description

**Type of issue**: bug report

The generated_src built using https://github.com/ucb-bar/chipyard.git repo has a issue. Noticed this issue with a fresh checkout this morning.
The following file has a issue at line 4794.
./generated-src/chipyard.harness.TestHarness.RocketConfig/chipyard.harness.TestHarness.RocketConfig.debug/VTestDriver__Trace__2__Slow.cpp

**Error with make run-binary-debug BINARY=test.riscv is as follows:**
VTestDriver__Trace__2__Slow.cpp: In function 'void VTestDriver___024root__trace_init_sub__TOP__4(VTestDriver___024root*, VerilatedVcd*)':
VTestDriver__Trace__2__Slow.cpp:4794:131: error: expected unqualified-id before ',' token
4794 | tracep->declQuad(c+47834,0,"channel",-1, VerilatedTraceSigDirection::NONE, VerilatedTraceSigKind::VAR, VerilatedTraceSigType::, false,-1, 63,0);
| ^
make[1]: *** [/home/dgangana/rocketchip/chipyard/.conda-env/share/verilator/include/verilated.mk:275: VTestDriver__Trace__2__Slow.o] Error 1

**Fix tried which worked is as follows:**
Changed the line from
tracep->declQuad(c+47834,0,"channel",-1, VerilatedTraceSigDirection::NONE, VerilatedTraceSigKind::VAR, VerilatedTraceSigType::, false,-1, 63,0);
to
tracep->declQuad(c+47834,0,"channel",-1, VerilatedTraceSigDirection::NONE, VerilatedTraceSigKind::VAR, VerilatedTraceSigType::LOGIC, false,-1, 63,0);

Please do the needful.

Contributor guide

Open the contributing guide

Research direction

Reproduce the failure with make run-binary-debug BINARY=test.riscv and inspect generated-src/chipyard.harness.TestHarness.RocketConfig/chipyard.harness.TestHarness.RocketConfig.debug/VTestDriver__Trace__2__Slow.cpp around line 4794. Trace how this generated declaration is produced, then verify that the build completes without manually editing the generated file.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.