chipsalliance / chipsalliance/rocket-chip
redundunt require
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 3.9k
- Forks
- 1.3k
- Avg merge
- 5d 13m
- Merged PRs (30d)
- 1
Description
https://github.com/chipsalliance/rocket-chip/blob/66a60e55a18fae859730b01c04450b2da3630e19/src/main/scala/tilelink/Fragmenter.scala#L93
This loc should be removed, because the following loc 97 seems already includes this require condition：
https://github.com/chipsalliance/rocket-chip/blob/66a60e55a18fae859730b01c04450b2da3630e19/src/main/scala/tilelink/Fragmenter.scala#L97
@hcook @terpstra
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/main/scala/tilelink/Fragmenter.scala and compare the require at line 93 with the condition at line 97. Confirm that the later condition fully covers the earlier one, remove the redundant location, and run the project's existing validation checks to ensure the Fragmenter behavior is unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100