chipsalliance / chipsalliance/rocket-chip

InwardNode(Line102) and OutwardNode(Line114) should be exchanged in the ascii art???

Open
#2,736 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Scala
Stars
3.9k
Forks
1.3k
Avg merge
5d 13m
Merged PRs (30d)
1

Description

https://github.com/chipsalliance/rocket-chip/blob/c28c051f85e0118195749549939be58ef9bfd19a/src/main/scala/diplomacy/package.scala#L102

I felt like the actual edge should always go from the lazymodule which has outward node to the lazymodule which has inward node, but in this ascii art, it seems that the two are reversed? is this a mistake, or I get something wrong?

Contributor guide

Open the contributing guide

Research direction

Start in src/main/scala/diplomacy/package.scala at lines 102 and 114, then trace how the ASCII-art graph represents inward and outward nodes. Confirm whether the rendered edge direction matches the node semantics described in the issue. The issue names no tests, so done means resolving the direction question and correcting the representation if it is reversed.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.