chipsalliance / chipsalliance/chisel

litValue is a confusing method name in testing code

Open
#2,109 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
4.8k
Forks
658
Avg merge
18h 59m
Merged PRs (30d)
14

Description

**Type of issue**: other enhancement

**Impact**: API addition (no impact on existing code)

ChiselTest returns a Chisel type on a ```peek()```. For more interesting tests we need to convert those into Scala land. ```litValue``` returns a ```BigInt```. However, the name is confusing as during testing those returned values are not constants/literals. They might change every clock cycle. The Proposal is to rename this method to ```asBigInt``` (adding it for now and maybe getting rid of ```litValue``` some time).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.