chipsalliance / chipsalliance/chisel

Verilog attribute annotations in modules are being lost when dedupping

Open
#1,846 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
4.8k
Forks
658
Avg merge
18h 59m
Merged PRs (30d)
14

Description

**Type of issue**: bug report

**Other information**

**If the current behavior is a bug, please provide the steps to reproduce the problem:**
Here is an example where a Verilog attribute is being emitted correctly if only one module is instantiated and not emitted when there are two duplicate modules.
https://scastie.scala-lang.org/Quarky93/SIjXX7lgRj2Q3iS19PA0Cg/22

I believe this also happens for memory initialisation annotations where $readmemh is generated.

**What is the current behavior?**
Verilog attribute is emitted correctly if only one module is instantiated and not emitted when there are duplicate modules after deduplication.

**What is the expected behavior?**
Attribute annotations should be kept after deduplication.

**Please tell us about your environment:**
chisel 3.4.2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.