chipsalliance / chipsalliance/chisel

Define isLit for Bundle Literals

Open
#1,084 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
4.8k
Forks
658
Avg merge
18h 59m
Merged PRs (30d)
14

Description

#1057 (bundle literals) is being merged as-is, where isLit on Bundles returns false. That may not be desired, though doing the opposite may break existing APIs (since isLit == true is probably followed by litArg, which would not exist for Bundle literals). Question is whether to make that work (and if not, how to define isLit - perhaps as 'is a numeric literal'?), or to recommend a different API for accessing Bundle literals such as one that returns an Option.

Also to be discussed would be how to support other Aggregate literal types that may come in the future, like Vec literals.

**Type of issue**: feature request

**Impact**: no functional change | API addition (no impact on existing code) | API modification | unknown

**Development Phase**: tracking

**Other information**

Contributor guide

Open the contributing guide

Research direction

Start by reading issue #1057 and the current Bundle literal behavior around isLit and litArg. Clarify whether isLit should include aggregate literals, whether an Option-based accessor is needed, and how future Vec literals should fit; the issue is done when the API semantics and compatibility impact are decided.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.