cginternals / cginternals/cppexpose
Variant array naming confusion
- Dominant language
- C
- Stars
- 28
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
`Variant::isArray()` and `Variant::asArray()` mean different things by 'Array' (array by means of the typed-library vs. `VariantArray` aka `std::vector`). `isVariantArray` is the actual type query function corresponding to `asArray`, so `asArray` should probably be renamed `asVariantArray`. Same goes for `asMap` & `isVariantMap`.
Contributor guide
No contributing guide indexed for this repository
Research direction
No files or tests are named. Start by locating Variant::isArray(), asArray(), isVariantArray, asMap(), and isVariantMap, then inspect their declarations and repository usages. Done means the naming consistently distinguishes typed-library arrays and VariantArray/VariantMap values without leaving mismatched call sites.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100