cginternals / cginternals/cppexpose

Variant array naming confusion

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
decision required enhancement
Dominant language
C
Stars
28
Forks
12
PR merge metrics
No merged PRs in 30d

Description

`Variant::isArray()` and `Variant::asArray()` mean different things by 'Array' (array by means of the typed-library vs. `VariantArray` aka `std::vector`). `isVariantArray` is the actual type query function corresponding to `asArray`, so `asArray` should probably be renamed `asVariantArray`. Same goes for `asMap` & `isVariantMap`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.