cefsharp / cefsharp/CefSharp

Core - Validate CachePath is direct child of RootCachePath

Abierto
#4,949 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
C#
Estrellas
10.3k
Forks
2.9k
Merge medio
5 d 22 h
PR fusionados (30 d)
4

Descripción

Yes this can be more subtle that one expects as well. Specifying an invalid cachepath causes it to default back if you are running multiple instances this is going to run into the singleton problem which if you have the handler for you might catch quickly but if not the crash may not be apparent.

I think the easiest decently bulletproof way to do this is something along the lines of:
```csharp
if (! String.IsNullOrWhitespace(CachePath)){
var di = DirectoryInfo(CachePath);
if (Path.GetRelativePath(di.FullPath,RootCachePath) != "." && Path.GetRelativePath(di.Parent.FullPath,RootCachePath) != ".")
throw new ArgumentException("If specifying CachePath it must be equal to the RootCachePath or a direct child directory of it");
}
```
(That is code from my poor memory so almost certainly won't compile but the gyst:)

Granted GetRelativePath is .net std 2.1 so doesn't help most .net framework users. Pretty sure there is GetFinalPath or getfinaltarget or something as well but i think that is an even newer .net version.

One could pinvoke with GetFinalPathNameByHandle but that might be overkill. Could just force users to not use tricky naming so CachePath.Parent must directly equal rootcachepath or throw an error (as cef probably is using basic logic to determine if it should allow the cachepath without full resolution like the above).

_Originally posted by @mitchcapper in https://github.com/cefsharp/CefSharp/issues/4925#issuecomment-2394952497_

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

El issue menciona CachePath y RootCachePath, pero no indica ningún archivo ni prueba; empieza localizando el manejo existente de las rutas de caché y comprobando cómo se tratan actualmente las rutas no válidas. Se considera terminado cuando un CachePath especificado solo se acepta si es igual a RootCachePath o es un hijo directo, rechazando claramente los valores no válidos en todas las versiones de .NET compatibles.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
csharp
Área
desktop
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.