cefsharp / cefsharp/CefSharp

Core - Validate CachePath is direct child of RootCachePath

Open
#4,949 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
10.3k
Forks
2.9k
Avg merge
5d 22h
Merged PRs (30d)
4

Description

Yes this can be more subtle that one expects as well. Specifying an invalid cachepath causes it to default back if you are running multiple instances this is going to run into the singleton problem which if you have the handler for you might catch quickly but if not the crash may not be apparent.

I think the easiest decently bulletproof way to do this is something along the lines of:
```csharp
if (! String.IsNullOrWhitespace(CachePath)){
var di = DirectoryInfo(CachePath);
if (Path.GetRelativePath(di.FullPath,RootCachePath) != "." && Path.GetRelativePath(di.Parent.FullPath,RootCachePath) != ".")
throw new ArgumentException("If specifying CachePath it must be equal to the RootCachePath or a direct child directory of it");
}
```
(That is code from my poor memory so almost certainly won't compile but the gyst:)

Granted GetRelativePath is .net std 2.1 so doesn't help most .net framework users. Pretty sure there is GetFinalPath or getfinaltarget or something as well but i think that is an even newer .net version.

One could pinvoke with GetFinalPathNameByHandle but that might be overkill. Could just force users to not use tricky naming so CachePath.Parent must directly equal rootcachepath or throw an error (as cef probably is using basic logic to determine if it should allow the cachepath without full resolution like the above).

_Originally posted by @mitchcapper in https://github.com/cefsharp/CefSharp/issues/4925#issuecomment-2394952497_

Contributor guide

Open the contributing guide

Research direction

The issue names CachePath and RootCachePath but no file or test; start by locating the existing cache-path handling and checking how invalid paths are currently treated. Done means a specified CachePath is accepted only when it equals RootCachePath or is a direct child, with invalid values rejected clearly across supported .NET versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.