cebe / cebe/php-openapi

BC break in 1.8

Offen
#247 1 Kommentar 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
PHP
Sterne
500
Forks
99
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Hi there,

The commit https://github.com/cebe/php-openapi/commit/219813f7e2826d782e6b705347dac654719b21ba introduces a backwards incompatible change to the security property of the OpenApi an Operation Classes. This is an issue, as the major version of the package stayed the same, which causes issues in packages which depend on this library, for example https://github.com/thephpleague/openapi-psr7-validator/issues/248. Also, the property documentation was not updated in accordance with the new change. I don't know if it's worth the trouble to reverse the change and reintroduce the change in a version 2 of this package, but you should be aware about the issues that were caused by this change.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Review commit 219813f7e2826d782e6b705347dac654719b21ba and the security property on the OpenApi Operation classes, then compare the compatibility concern with the linked validator issue. Check the property's documentation for the stated mismatch. Done requires an agreed resolution for the 1.8 compatibility break and documentation that matches the resulting behavior.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
php
Bereich
api
Issue-Typ
Bug
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Veraltet
Klarheit
Muss geklärt werden
Anfängerfreundlichkeit
25/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.