carpentries-incubator / carpentries-incubator/python-intermediate-development

Missing Patient class

Open
#415 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TeX
Stars
63
Forks
77
Avg merge
20h 8m
Merged PRs (30d)
3

Description

The extras episodes on [persistence](https://carpentries-incubator.github.io/python-intermediate-development/persistence.html) and [databases](https://carpentries-incubator.github.io/python-intermediate-development/databases.html) assume a Patient class is in the inflammation project. This class was removed with the new section 3.

The test [ `test_patient.py`](https://github.com/carpentries-incubator/python-intermediate-inflammation/blob/main/tests/test_patient.py) refers to a models.Patient class but it does not exist in [models.py](https://github.com/carpentries-incubator/python-intermediate-inflammation/blob/main/inflammation/models.py).

We could easily fix this by adding the Patient class back to models.py:
```python
class Observation:
def __init__(self, day, value):
self.day = day
self.value = value

def __str__(self):
return str(self.value)

class Patient:
"""A patient in an inflammation study."""
def __init__(self, name):
self.name = name
self.observations = []

def add_observation(self, value, day=None):
if day is None:
try:
day = self.observations[-1].day + 1

except IndexError:
day = 0

new_observation = Observation(day, value)

self.observations.append(new_observation)
return new_observation

def __str__(self):
return self.name

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.