caolan / caolan/nodeunit

missing uglify-js, make browser fails on sed

Open
#111 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.9k
Forks
359
PR merge metrics
No merged PRs in 30d

Description

## Expected
1. uglify-js should be a dev-dependency in npm `package.json`
2. `make browser` builds correctly
## Actual

Output as follows...

```
# super hacky build script for browser version!
# etc...
echo "nodeunit.run = reporter.run;" >> dist/browser/nodeunit.js
echo "return nodeunit; })();" >> dist/browser/nodeunit.js
sed -i "/\@REMOVE_LINE_FOR_BROWSER/d" dist/browser/nodeunit.js
sed: 1: "dist/browser/nodeunit.js": extra characters at the end of d command
make: *** [browser] Error 1
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Read npm package.json and the make browser target, then run make browser to reproduce the sed failure. Done means uglify-js is declared as a dev dependency and the browser build completes without the reported error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.