canonical / canonical/layer-basic
Improve series upgrade handling by allowing for manual venv rebuild
- Lenguaje dominante
- Python
- Estrellas
- 10
- Forks
- 42
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
It is likely that an admin will want to validate that the charm code will be successful after a series upgrade before issuing the `juju upgrade-series complete` command. However, the [current logic](https://github.com/juju-solutions/layer-basic/blob/master/lib/charms/layer/basic.py#L116-L119) will [only trigger on the `post-series-upgrade` hook](https://github.com/juju-solutions/layer-basic/blob/master/lib/charms/layer/basic.py#L102) which doesn't allow the admin a chance to validate the new venv.
I think we should add a `--rebuild` option to the [`charm-env` command](https://github.com/juju-solutions/layer-basic/blob/master/bin/charm-env) which does the venv rebuild manually and presumably sets a flag to indicate to the bootstrap code that it has already been rebuilt for the current series so that it doesn't get rebuilt again upon `post-series-upgrade`.
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Comienza con bin/charm-env y la lógica de series-upgrade citada en lib/charms/layer/basic.py, incluido el hook de post-series-upgrade. Rastrea cómo se reconstruye el entorno virtual y cómo se registra el estado de la series; se considera terminado cuando --rebuild admite la validación previa a la finalización y el hook no vuelve a reconstruir la misma series.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- devops, tooling
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 38/100